"She was only a moonshiner’s daughter, but he loved her still” is an old pun on the word “still” (that can also mean “distillery"). “She may be only a moonshiner’s daughter, but I love her still” has been cited in print since at least 1921.
“She was only a whiskey maker, but he loved her still” has been cited in print since at least 2004 and is a popular modern form of the pun.
Free Merriam-Webster Dictionary
Definition of STILL
2: apparatus used in distillation comprising either the chamber in which the vaporization is carried out or the entire equipment
First Known Use of STILL
10 January 1921, Kokomo (IN) Tribune, pg. 6. col. 4:
In this connection they’re singing a new song—“She May Be Only a Moonshiner’s Daughter But I Love Her Still.”
15 November 1927, The Register (Sandusky, IL), “Noah Numskull” comic, pg. 11, col. 1:
DEAR NOAH:—EVEN IF MY GIRL IS A MOONSHINER’S DAUGHTER, SHOULD I LOVE HER STILL?
WEST BURLINGTON, IOWA
9 February 1928, The Bee (Danville, VA), “Scoop’s Colyum,” pg. 4, col. 4:
She Was Only a Moonshiner’s Daughter, But He Loved Her Still.
13 June 1941, Ogden (UT) Standard-Examiner, “Sol’s Sunshine and Shadow,” pg. 8B, col. 6:
She was the moonshiner’s daughter, but he loved her still.
20 July 1969, The Times-Picayune (New Orleans, LA), “Weekend Chuckles,” sec. 7, pg. 5, col. 2:
She was only a moonshiner’s daughter, but he loved her still.
The Second Oldest Profession;
An Informal History of Moonshining in America
By Jess Carr
Englewood Cliffs, NJ: Prentice-Hall
The old pun “she was a moonshiner’s daughter but he loved her still,” brings to mind another colorful aspect of the moonshiner’s social life and customs.
She was only a poteen makers daughter - but he loved her still.
She was only a whiskey maker, but he loved her still.
Yahoo! Groups—Puns of the Day
Sun Oct 2, 2005 6:36 pm
From: Joanna Brietmeyer
100 best one liners
16. She was only a whisky maker but he loved her still.
Recipes, tall tales, drinking songs, historical stuff, knee-slappers, how to make it, how to drink it, pleasin’ the law, recoverin’ the next day
By Matthew B. Rowley
New York, NY: Lark Books
She was just a moonshiner’s daughter, but he loved her still.